[Xmltv-devel] [ xmltv-Bugs-2158488 ] _ar: Use of uninitialized value in string ne

[SourceForge.net]

Bugs item #2158488, was opened at 2008-10-11 03:19
Message generated for change (Comment added) made by dekarl
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=2158488&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_grab_ar
Group: None

Status: Closed
Resolution: Fixed

Priority: 5
Private: No
Submitted By: dahool (dahool)
Assigned to: Christian Rodriguez (car_unlp)
Summary: _ar: Use of uninitialized value in string ne

Initial Comment:
The error is reported in line 310, though the real error is in line 309.

There is an infinite while loop.

I don't know much about Perl, but I did some changes and it seems to work, this is the modified code:

foreach my $ch_did (@channels) {
my $index=0;
my $ch_name=$channels{$ch_did};
my $ch_xid="$ch_did.cablevision";
while (defined(${$ch_all[$index]}{'id'}) and ${$ch_all[$index]}{'id'} ne $ch_xid) {
$index++;
}
if (defined(${$ch_all[$index]}{'id'})) {
my $ch_num=${ch_all[$index]}{'channel-num'};
$writer->write_channel({ id => $ch_xid,
'display-name' => [ [ $ch_name ],
[ $ch_num ] ] });
my $day=UnixDate($now,'%Q');
for (my $i=0;$i<$opt_days;$i++) {
push @to_get, [ $day, $ch_did, $ch_num ];
#for each day
$day=nextday($day); die if not defined $day;
}
}
}

As you can see, I added defined(${$ch_all[$index]}{'id'} to check whatever the index is defined.

Maybe there is a better way, but Perl is not my specialty.

I'm using xmltv-grabbers 0.5.53-0.pm.0 packaged by packman.links2linux.de for openSUSE.


----------------------------------------------------------------------

Comment By: Karl Dietz (dekarl)

Date: 2010-11-15 21:15

Message:
seems to have been fixed before the grabber broke

----------------------------------------------------------------------

Comment By: Karl Dietz (dekarl)
Date: 2010-10-25 11:44

Message:
Can we close this as fixed before the grabber broke and got pulled from the
build six weeks ago?


----------------------------------------------------------------------

Comment By: Chris Butler (crispygoth)
Date: 2010-08-05 16:30

Message:
I'm getting this error when the test scripts run the _ar grabber from
0.5.57 with the test.conf also released in 0.5.57. It looks like it's fixed
in CVS, so I've just disabled _ar in the automated test for now.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=2158488&group_id=39046