[Xmltv-devel] [ xmltv-Bugs-3315805 ] Unwanted additional empty star-rating tag added by tv_imdb

[SourceForge.net]

Bugs item #3315805, was opened at 2011-06-13 18:21
Message generated for change (Tracker Item Submitted) made by user1024
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_imdb
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: user1024 (user1024)
Assigned to: Jerry Veldhuis (jveldhuis)
Summary: Unwanted additional empty star-rating tag added by tv_imdb

Initial Comment:
My aim is to use tv_imdb to replace the star-rating xml tag with a rating from imdb. To do this I have edited tv_imdb so that the IMDB object has replaceStarRatings argument set to true (i.e. "my $imdb=new XMLTV::IMDB('imdbDir' => $opt_imdbDir, ... 'replaceStarRatings' => 1);").

However I found that the output xml file contained an additional emtpy star-rating tag just after the correctly altered star-rating tag.

Attached is a suggested patch.

Thanks

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

[SourceForge.net]

Bugs item #3315805, was opened at 2011-06-13 12:21
Message generated for change (Comment added) made by rmeden
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_imdb
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: user1024 (user1024)
Assigned to: Jerry Veldhuis (jveldhuis)
Summary: Unwanted additional empty star-rating tag added by tv_imdb

Initial Comment:
My aim is to use tv_imdb to replace the star-rating xml tag with a rating from imdb. To do this I have edited tv_imdb so that the IMDB object has replaceStarRatings argument set to true (i.e. "my $imdb=new XMLTV::IMDB('imdbDir' => $opt_imdbDir, ... 'replaceStarRatings' => 1);").

However I found that the output xml file contained an additional emtpy star-rating tag just after the correctly altered star-rating tag.

Attached is a suggested patch.

Thanks

----------------------------------------------------------------------

Comment By: Robert Eden (rmeden)

Date: 2011-06-13 16:08

Message:
why do you want to *replace* a tag. Doesn't tv_imdb add a new one listing
itself as the source of the ratings? I believe the <ratings> tag is
designed to have multiple ratings.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

[SourceForge.net]

Bugs item #3315805, was opened at 2011-06-13 18:21
Message generated for change (Comment added) made by user1024
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_imdb
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: user1024 (user1024)
Assigned to: Jerry Veldhuis (jveldhuis)
Summary: Unwanted additional empty star-rating tag added by tv_imdb

Initial Comment:
My aim is to use tv_imdb to replace the star-rating xml tag with a rating from imdb. To do this I have edited tv_imdb so that the IMDB object has replaceStarRatings argument set to true (i.e. "my $imdb=new XMLTV::IMDB('imdbDir' => $opt_imdbDir, ... 'replaceStarRatings' => 1);").

However I found that the output xml file contained an additional emtpy star-rating tag just after the correctly altered star-rating tag.

Attached is a suggested patch.

Thanks

----------------------------------------------------------------------

Comment By: user1024 (user1024)
Date: 2011-06-14 18:07

Message:
Thanks for looking into this.

There is a comment in xmltv/lib/IMDB.pm which says "current xmltv 0.5
doens't support more than one star rating". Therefore I would like to
replace the existing star-rating with the IMDB star-rating.

Below is an example which shows the difference between the <rating> and
<star-rating> tags.

<programme start="20110529110000 +0100" stop="20110529125500 +0100"
channel="filmfour.channel4.com">
<title>The Enemy Below</title>
...
<rating system="BBFC">
<value>PG</value>
</rating>
<star-rating>
<value>4/5</value>
</star-rating>
</programme>

----------------------------------------------------------------------

Comment By: Robert Eden (rmeden)
Date: 2011-06-13 22:08

Message:
why do you want to *replace* a tag. Doesn't tv_imdb add a new one listing
itself as the source of the ratings? I believe the <ratings> tag is
designed to have multiple ratings.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

[SourceForge.net]

Bugs item #3315805, was opened at 2011-06-13 19:21
Message generated for change (Comment added) made by dekarl
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_imdb
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: user1024 (user1024)
Assigned to: Jerry Veldhuis (jveldhuis)
Summary: Unwanted additional empty star-rating tag added by tv_imdb

Initial Comment:
My aim is to use tv_imdb to replace the star-rating xml tag with a rating from imdb. To do this I have edited tv_imdb so that the IMDB object has replaceStarRatings argument set to true (i.e. "my $imdb=new XMLTV::IMDB('imdbDir' => $opt_imdbDir, ... 'replaceStarRatings' => 1);").

However I found that the output xml file contained an additional emtpy star-rating tag just after the correctly altered star-rating tag.

Attached is a suggested patch.

Thanks

----------------------------------------------------------------------

Comment By: Karl Dietz (dekarl)

Date: 2011-06-18 14:50

Message:
find attached a patch that fixes the star-rating in tv_imdb. IMDB User
Ratings get added in front of all existing ratings. I'm attaching it here
as I have only lightly tested it (on _uk_rt which has between 0 and 2
star-ratings on its programmes already) and the release is near

----------------------------------------------------------------------

Comment By: user1024 (user1024)
Date: 2011-06-14 19:07

Message:
Thanks for looking into this.

There is a comment in xmltv/lib/IMDB.pm which says "current xmltv 0.5
doens't support more than one star rating". Therefore I would like to
replace the existing star-rating with the IMDB star-rating.

Below is an example which shows the difference between the <rating> and
<star-rating> tags.

<programme start="20110529110000 +0100" stop="20110529125500 +0100"
channel="filmfour.channel4.com">
<title>The Enemy Below</title>
...
<rating system="BBFC">
<value>PG</value>
</rating>
<star-rating>
<value>4/5</value>
</star-rating>
</programme>

----------------------------------------------------------------------

Comment By: Robert Eden (rmeden)
Date: 2011-06-13 23:08

Message:
why do you want to *replace* a tag. Doesn't tv_imdb add a new one listing
itself as the source of the ratings? I believe the <ratings> tag is
designed to have multiple ratings.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

[SourceForge.net]

Bugs item #3315805, was opened at 2011-06-13 19:21
Message generated for change (Comment added) made by dekarl
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv_imdb
Group: None

Status: Closed
Resolution: Fixed

Priority: 5
Private: No
Submitted By: user1024 (user1024)

Assigned to: Karl Dietz (dekarl)

Summary: Unwanted additional empty star-rating tag added by tv_imdb

Initial Comment:
My aim is to use tv_imdb to replace the star-rating xml tag with a rating from imdb. To do this I have edited tv_imdb so that the IMDB object has replaceStarRatings argument set to true (i.e. "my $imdb=new XMLTV::IMDB('imdbDir' => $opt_imdbDir, ... 'replaceStarRatings' => 1);").

However I found that the output xml file contained an additional emtpy star-rating tag just after the correctly altered star-rating tag.

Attached is a suggested patch.

Thanks

----------------------------------------------------------------------

Comment By: Karl Dietz (dekarl)

Date: 2011-07-02 19:32

Message:
a fix was commited on June 22th

----------------------------------------------------------------------

Comment By: Karl Dietz (dekarl)
Date: 2011-06-18 14:50

Message:
find attached a patch that fixes the star-rating in tv_imdb. IMDB User
Ratings get added in front of all existing ratings. I'm attaching it here
as I have only lightly tested it (on _uk_rt which has between 0 and 2
star-ratings on its programmes already) and the release is near

----------------------------------------------------------------------

Comment By: user1024 (user1024)
Date: 2011-06-14 19:07

Message:
Thanks for looking into this.

There is a comment in xmltv/lib/IMDB.pm which says "current xmltv 0.5
doens't support more than one star rating". Therefore I would like to
replace the existing star-rating with the IMDB star-rating.

Below is an example which shows the difference between the <rating> and
<star-rating> tags.

<programme start="20110529110000 +0100" stop="20110529125500 +0100"
channel="filmfour.channel4.com">
<title>The Enemy Below</title>
...
<rating system="BBFC">
<value>PG</value>
</rating>
<star-rating>
<value>4/5</value>
</star-rating>
</programme>

----------------------------------------------------------------------

Comment By: Robert Eden (rmeden)
Date: 2011-06-13 23:08

Message:
why do you want to *replace* a tag. Doesn't tv_imdb add a new one listing
itself as the source of the ratings? I believe the <ratings> tag is
designed to have multiple ratings.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3315805&group_id=39046