[Xmltv-devel] [PATCH] Handle movies with episodes as series

[pmhahn+]

From: Philipp Matthias Hahn <pmhahn+***@pmhahn.de>

MythTV assumes a movie title to be unique and uses it to detect
duplicates. This breaks recordings like the German crime series
"Tator", which are categorized as "movie" by egpdata.com.

Unfortunately the XMLTV XML format has now unique identifier for
programs, which would allow tv_grab_eu_epgdata to pass d2=tvshow_id to
MythTV, which could use that as its 'programid'.

See <https://code.mythtv.org/trac/ticket/12121> for the MythTV ticket.
---
tv_grab_eu_epgdata | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tv_grab_eu_epgdata b/tv_grab_eu_epgdata
index 9e0d716..28d6314 100755
--- a/tv_grab_eu_epgdata
+++ b/tv_grab_eu_epgdata
@@ -482,7 +482,12 @@ sub printepg {

# use hardcoded categories for mythtv
if ($category eq '100') {
- push @{$prog{'category'}}, [ 'movie' ];
+ # <https://code.mythtv.org/trac/ticket/12121> MythTV uses movie titles as unique identifiers for duplicate detection
+ if ($sequence gt 0) {
+ push @{$prog{'category'}}, [ 'series' ];
+ } else {
+ push @{$prog{'category'}}, [ 'movie' ];
+ }
} elsif ($category eq '200') {
push @{$prog{'category'}}, [ 'series' ];
} elsif ($category eq '300') {

[Ben Bucksch]

Post by pmhahn+
MythTV assumes a movie title to be unique and uses it to detect
duplicates. This breaks recordings like the German crime series
"Tator", which are categorized as "movie" by egpdata.com.
Unfortunately the XMLTV XML format has now unique identifier for
programs, which would allow tv_grab_eu_epgdata to pass d2=tvshow_id to
MythTV, which could use that as its 'programid'.

Review:
Just about the code documentation/comments:

Make a comment that cat = 100 is a movie in Epgdata.com:
if ($category eq '100') { // movie
and then comment:
// some programs marked as "movies" are actually series
// with long episodes, e.g. German "Tatort".
// They have a sequence number, though, so detect them like that
if ...


What MythTV does with it is both correct and irrelevant, because it's a
bug in the source. The bug you are fixing is that a series is marked as
movie in epgdata, and that's independent from a program. Thus, you don't
need to mention MythTV in the comment.

Post by pmhahn+
See <https://code.mythtv.org/trac/ticket/12121> for the MythTV ticket.
---
tv_grab_eu_epgdata | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tv_grab_eu_epgdata b/tv_grab_eu_epgdata
index 9e0d716..28d6314 100755
--- a/tv_grab_eu_epgdata
+++ b/tv_grab_eu_epgdata
@@ -482,7 +482,12 @@ sub printepg {
# use hardcoded categories for mythtv
if ($category eq '100') {
+ # <https://code.mythtv.org/trac/ticket/12121> MythTV uses movie titles as unique identifiers for duplicate detection
+ if ($sequence gt 0) {
+ } else {
+ }
} elsif ($category eq '200') {
} elsif ($category eq '300') {