Discussion:
[Xmltv-devel] _ar: initial test
Karl Dietz
2011-01-24 19:38:58 UTC
Permalink
Hi Mariano,

I've seen your commit to _ar and tried it to see if makes sense to
enable it in the Makefile.

There are some minor things, but nothing major so I'd like to enable it
soon.

1) running the new grabber with an old configuration does not work and
does not give a useful error message. I'd prefer if there was some
default handling that at least gives the user a hint on what is
wrong. (As long as there is no defined general way of returning
"the grabber needs a new configuration")
Maybe just make "Cablevision zone 3" the default for old
configurations?
Use of uninitialized value $locationid in concatenation (.) or string
at /home/nonametv/xmltv/grab/../blib/script/tv_grab_ar line 656.
2) the grabber is not quiet.
main::select_Location() called too early to check prototype at
/home/nonametv/xmltv/grab/../blib/script/tv_grab_ar line 271.
Readding it to the build is easy, just enable the block about _ar when
commiting the next time.

Regards,
Karl
Mariano Cosentino
2011-01-24 23:17:03 UTC
Permalink
Dear Karl,
thanks for the feedback !
I had uploaded a new version a few minutes ago with this 2 fixes.

Regarding Item 1, The old configuration file is not
compatible with the new now as the channel IDs have changed in the
source, so I added a check to force the user to run the --configure if
the location is not there (I will assume that this means that the
config file is old).
Post by Karl Dietz
I've seen your commit to _ar and tried it to see if makes sense to
enable it in the Makefile.
Do we have a time frame for the next release ??
There are a few changes I have in mind, but I'm not sure if I'll be
able to make them before our baby arrives (anytime now), so decided to
release a working version and keep those changes for a later day.
If i can do the changes in time I'll upload the new versions, if not
this version should be good enough to release.
Post by Karl Dietz
Readding it to the build is easy, just enable the block about _ar when
commiting the next time.
Sorry, I did not get this ... I'm new to the CVS system ...

Best regards, Marianok
Karl Dietz
2011-01-25 00:08:51 UTC
Permalink
Hello Mariano,
Post by Mariano Cosentino
Regarding Item 1, The old configuration file is not
compatible with the new now as the channel IDs have changed in the
source, so I added a check to force the user to run the --configure if
the location is not there (I will assume that this means that the
config file is old).
Strange, I have just commited an updated test.conf and the only change
seems to be the location. The channel numbers and names appear to be
the same. That's why I had the idea to add "0" as default location.
Post by Mariano Cosentino
Post by Karl Dietz
I've seen your commit to _ar and tried it to see if makes sense to
enable it in the Makefile.
Do we have a time frame for the next release ??
Continue reading on narkive:
Loading...